Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO: Add docker-buildx #18487

Merged
merged 4 commits into from
Jul 22, 2024
Merged

ISO: Add docker-buildx #18487

merged 4 commits into from
Jul 22, 2024

Conversation

spowelljr
Copy link
Member

@spowelljr spowelljr commented Mar 21, 2024 •
edited
Loading

Before:

$ docker build
DEPRECATED: The legacy builder is deprecated and will be removed in a future release.
            Install the buildx component to build images with BuildKit:
            https://docs.docker.com/go/buildx/

"docker build" requires exactly 1 argument.
See 'docker build --help'.

Usage:  docker build [OPTIONS] PATH | URL | -

Build an image from a Dockerfile

After:

$ docker build       
ERROR: "docker buildx build" requires exactly 1 argument.
See 'docker buildx build --help'.

Usage:  docker buildx build [OPTIONS] PATH | URL | -

Start a build

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 21, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 21, 2024
@spowelljr spowelljr changed the title Add docker buildx iso ISO: Add docker-buildx Mar 21, 2024
@spowelljr
Copy link
Member Author

ok-to-build-iso

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 29, 2024
@spowelljr spowelljr force-pushed the addDockerBuildxISO branch from 340eb43 to 7edd6d2 Compare March 29, 2024 20:50
@spowelljr
Copy link
Member Author

ok-to-build-iso

1 similar comment
@medyagh
Copy link
Member

medyagh commented Jun 17, 2024

ok-to-build-iso

@spowelljr spowelljr force-pushed the addDockerBuildxISO branch from 7edd6d2 to ead0293 Compare July 9, 2024 19:28
@spowelljr spowelljr force-pushed the addDockerBuildxISO branch from ead0293 to 74deca6 Compare July 19, 2024 14:08
@spowelljr spowelljr force-pushed the addDockerBuildxISO branch from 74deca6 to 2f3c844 Compare July 19, 2024 14:14
@spowelljr
Copy link
Member Author

ok-to-build-iso

@spowelljr
Copy link
Member Author

ok-to-build-iso

@spowelljr
Copy link
Member Author

ok-to-build-iso

@minikube-bot
Copy link
Collaborator

Hi @spowelljr, we have updated your PR with the reference to newly built ISO. Pull the changes locally if you want to test with them or update your PR further.

@spowelljr
Copy link
Member Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 20, 2024
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18487) |
+----------------+----------+---------------------+
| minikube start | 48.1s    | 48.5s               |
| enable ingress | 24.5s    | 24.1s               |
+----------------+----------+---------------------+

Times for minikube start: 47.6s 48.3s 49.5s 47.0s 48.1s
Times for minikube (PR 18487) start: 51.5s 45.8s 46.5s 50.5s 48.0s

Times for minikube ingress: 25.0s 23.0s 26.9s 23.9s 23.9s
Times for minikube (PR 18487) ingress: 22.9s 23.9s 22.9s 23.4s 27.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18487) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 23.3s               |
| enable ingress | 22.1s    | 22.7s               |
+----------------+----------+---------------------+

Times for minikube start: 21.2s 23.7s 24.5s 24.0s 21.2s
Times for minikube (PR 18487) start: 24.3s 24.0s 21.3s 24.1s 22.5s

Times for minikube ingress: 21.8s 23.2s 21.2s 21.7s 22.7s
Times for minikube (PR 18487) ingress: 22.7s 22.2s 21.8s 20.8s 25.8s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 18487) |
+----------------+----------+---------------------+
| minikube start | 21.1s    | 21.6s               |
| enable ingress | 44.5s    | 45.9s               |
+----------------+----------+---------------------+

Times for minikube (PR 18487) start: 22.7s 22.4s 21.8s 19.9s 21.1s
Times for minikube start: 22.3s 20.1s 21.1s 22.5s 19.4s

Times for minikube ingress: 39.2s 48.3s 39.2s 47.7s 47.9s
Times for minikube (PR 18487) ingress: 37.3s 48.2s 47.7s 48.2s 48.2s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
KVM_Linux_containerd (4 failed) TestNetworkPlugins/group/enable-default-cni/NetCatPod(gopogh) 0.00% (chart)
KVM_Linux_containerd (4 failed) TestAddons/parallel/InspektorGadget(gopogh) 0.65% (chart)
KVM_Linux_containerd (4 failed) TestAddons/StoppedEnableDisable(gopogh) 0.65% (chart)

Besides the following environments also have failed tests:

To see the flake rates of all tests by environment, click here.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spowelljr spowelljr merged commit 1d227ad into kubernetes:master Jul 22, 2024
29 of 40 checks passed
@spowelljr spowelljr deleted the addDockerBuildxISO branch July 22, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ComradeProgrammer ComradeProgrammer ComradeProgrammer approved these changes

@afbjorklund afbjorklund Awaiting requested review from afbjorklund

@medyagh medyagh Awaiting requested review from medyagh

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spowelljr @medyagh @minikube-bot @minikube-pr-bot @k8s-ci-robot @ComradeProgrammer